Page MenuHomePhabricator

The pipe2(2) call is supported on NetBSD
ClosedPublic

Authored by krytarowski on Sep 9 2015, 6:15 PM.

Details

Summary

Linux and NetBSD versions are compatible, modulo flag values:

  • O_CLOEXEC and O_NONBLOCK are the same,
  • O_NOSIGPIPE on NetBSD,
  • O_DIRECT on Linux.

Diff Detail

Repository
rL LLVM

Event Timeline

krytarowski updated this revision to Diff 34398.Sep 9 2015, 6:15 PM
krytarowski retitled this revision from to The pipe2(2) call is supported on NetBSD.
krytarowski updated this object.
krytarowski added a reviewer: joerg.
krytarowski set the repository for this revision to rL LLVM.
krytarowski added a subscriber: lldb-commits.
sas accepted this revision.Sep 10 2015, 9:59 AM
sas added a reviewer: sas.
This revision is now accepted and ready to land.Sep 10 2015, 9:59 AM
emaste added a subscriber: emaste.Sep 10 2015, 4:44 PM
emaste added inline comments.
source/Host/posix/PipePosix.cpp
39 ↗(On Diff #34398)

My preference is that we don't repeat the list of platforms in the comments when we have cases like this - perhaps just change to // pipe2 is supported by a limited set of platforms or so?

Presumably you're only interested in recent NetBSD versions while getting support working?

krytarowski added inline comments.Sep 10 2015, 4:49 PM
source/Host/posix/PipePosix.cpp
39 ↗(On Diff #34398)

I will rediff the comment.

Yes, I'm just interested with the -current version. I'm working with the NetBSD to add missing bits to extend the system capabilities for larger possibe lldb support.

krytarowski edited edge metadata.

rediff the comment

Please commit it if it's OK.

This revision was automatically updated to reflect the committed changes.