Page MenuHomePhabricator

New RenderScript command to break on all kernels
ClosedPublic

Authored by EwanCrawford on Sep 9 2015, 7:18 AM.

Details

Summary

Patch adds a command to RenderScript plugin allowing users to automatically set breakpoints on every RS kernel.

Command syntax is 'language renderscript kernel breakpoint all <enable/disable>.'
Enable sets breakpoints on all currently loaded kernels, and any kernels which will be loaded in future.
Disable results in breakpoints no longer being set on loaded kernels, but doesn't affect existing breakpoints.

Current command 'language renderscript kernel breakpoint' is changed to 'language renderscript kernel breakpoint set'

Diff Detail

Event Timeline

EwanCrawford retitled this revision from to New RenderScript command to break on all kernels.
EwanCrawford updated this object.
EwanCrawford added reviewers: clayborg, jingham.
EwanCrawford set the repository for this revision to rL LLVM.
jingham accepted this revision.Sep 9 2015, 12:33 PM
jingham edited edge metadata.

This looks fine to me. You might want to add LIBLLDB_LOG_BREAKPOINT to your log creation, you can them together, and if I was tracking breakpoints with "log enable lldb breakpoint" I'd expect to see these logs.

You might also consider giving all your kernel breakpoints some convenient name (using Breakpoint::AddName) That would allow users, e.g. to disable all the breakpoints set on kernels, or add hit counts, etc. When I get a little spare time I'm going to add the ability to add breakpoint commands to a name, and have it apply to all breakpoints with that name, so that will make this even more useful. If you do this, just be sure to choose something like RenderScriptKernel or whatever that won't be a commonly chosen name.

This revision is now accepted and ready to land.Sep 9 2015, 12:33 PM
This revision was automatically updated to reflect the committed changes.