This is an archive of the discontinued LLVM Phabricator instance.

Add Myriad into enum VendorType.
ClosedPublic

Authored by dougk on Sep 1 2015, 2:43 PM.

Details

Summary

Myriad isn't really the vendor, but this maintains compatibility with an existing gcc triple.
Doing it any other way (such as spelling Movidius as "myriad") is just asking for trouble.

Diff Detail

Repository
rL LLVM

Event Timeline

dougk updated this revision to Diff 33730.Sep 1 2015, 2:43 PM
dougk retitled this revision from to Add Myriad into enum VendorType..
dougk updated this object.
dougk added reviewers: jyknight, chandlerc.
dougk added a subscriber: llvm-commits.
jyknight edited edge metadata.Sep 2 2015, 2:59 PM

Seems sensible to me, but not sure if anyone else wants to object to the erroneous usage.

chandlerc edited edge metadata.Sep 2 2015, 3:15 PM
chandlerc added a subscriber: chandlerc.

LGTM

Looks fine. Sad but fine :)

-eric

This revision was automatically updated to reflect the committed changes.