Page MenuHomePhabricator

Fix SEGV in InlineAsm::ConstraintInfo::Parse.
ClosedPublic

Authored by kschimpf on Sep 1 2015, 2:22 PM.

Details

Summary

Fixes bug 24646. Previous code was not checking if an index into a vector
was valid, resulting in a SEGV. Fixed by assuming the construct can't
be parsed when given this input.

Reformat and add test.

Diff Detail

Repository
rL LLVM

Event Timeline

kschimpf updated this revision to Diff 33726.Sep 1 2015, 2:22 PM
kschimpf retitled this revision from to Fix SEGV in InlineAsm::ConstraintInfo::Parse..
kschimpf updated this object.
kschimpf updated this revision to Diff 33731.Sep 1 2015, 2:39 PM

Remove binary characters from test file.

kschimpf added a subscriber: llvm-commits.
kcc edited edge metadata.Sep 1 2015, 2:47 PM

LGTM, but I am not sure if my LGTM is enough for this code.

Anyone, any objections?

jtsoftware accepted this revision.Sep 2 2015, 5:04 PM
jtsoftware edited edge metadata.

LGTM. Thanks!

This revision is now accepted and ready to land.Sep 2 2015, 5:04 PM
This revision was automatically updated to reflect the committed changes.