Fix SEGV in InlineAsm::ConstraintInfo::Parse.

[kschimpf]

Summary

Fixes bug 24646. Previous code was not checking if an index into a vector
was valid, resulting in a SEGV. Fixed by assuming the construct can't
be parsed when given this input.

Reformat and add test.

[kschimpf]

Remove binary characters from test file.

[kcc]

LGTM, but I am not sure if my LGTM is enough for this code.

Anyone, any objections?

[jtsoftware]

LGTM. Thanks!

llvm/trunk/lib/IR/InlineAsm.cpp

if (*I == '{') {   // Physical register reference.
       // Check that this is a valid matching constraint!
       if (N >= ConstraintsSoFar.size() || ConstraintsSoFar[N].Type != isOutput||
           Type != isInput)
         return true;  // Invalid constraint number.
       
       // If Operand N already has a matching input, reject this.  An output
       // can't be constrained to the same value as multiple inputs.
       if (isMultipleAlternative) {
-        if (multipleAlternativeIndex >= ConstraintsSoFar[N].multipleAlternatives.size())
+        if (multipleAlternativeIndex >=
+            ConstraintsSoFar[N].multipleAlternatives.size())
           return true;
         InlineAsm::SubConstraintInfo &scInfo =
           ConstraintsSoFar[N].multipleAlternatives[multipleAlternativeIndex];
         if (scInfo.MatchingInput != -1)
           return true;
         // Note that operand #n has a matching input.
         scInfo.MatchingInput = ConstraintsSoFar.size();
       } else {