This is an archive of the discontinued LLVM Phabricator instance.

Implement DoReadMemory for Windows mini dumps
ClosedPublic

Authored by amccarth on Aug 31 2015, 4:46 PM.

Details

Summary

Implements DoReadMemory for Windows mini dumps. The dumps can use two slightly different methods for capturing ranges of memory, so I abstracted away the search for a range from the actual reading of the range.

Also a trivial fix to avoid the warning that quitting the debugging will terminate the process.

Diff Detail

Event Timeline

amccarth updated this revision to Diff 33644.Aug 31 2015, 4:46 PM
amccarth retitled this revision from to Implement DoReadMemory for Windows mini dumps.
amccarth updated this object.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
zturner accepted this revision.Sep 1 2015, 9:45 AM
zturner edited edge metadata.
zturner added inline comments.
source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp
249–252

Yea, a lazily constructed index seems like it would be a good idea. For those dumps which don't contain full heap information this will probably be pretty quick, but if a dump has full heap information this is going to be a huge slowdown.

Not something we have to worry about right now, but we'll need to address it eventually.

This revision is now accepted and ready to land.Sep 1 2015, 9:45 AM
This revision was automatically updated to reflect the committed changes.