This is an archive of the discontinued LLVM Phabricator instance.

Silence some MSVC warnings.
ClosedPublic

Authored by sas on Aug 26 2015, 4:43 PM.

Details

Summary

Just assert("string" && false) instead of assert("string" == NULL).

This avoid errors like

[...]\Core\SourceManager.cpp(647): warning C4130: '==' : logical operation on address of string constant

Diff Detail

Event Timeline

sas updated this revision to Diff 33275.Aug 26 2015, 4:43 PM
sas retitled this revision from to Silence some MSVC warnings..
sas updated this object.
sas added a reviewer: zturner.
sas added a subscriber: lldb-commits.
zturner edited edge metadata.Aug 26 2015, 4:45 PM
zturner added a subscriber: zturner.

Thanks for fixing these. Feel free to commit trivial warning fixes without
review.

This revision was automatically updated to reflect the committed changes.