This is an archive of the discontinued LLVM Phabricator instance.

Extend linux header search to find libc++ headers in c++/vN for any N.
ClosedPublic

Authored by eugenis on Aug 26 2015, 3:14 PM.

Details

Summary

This goes with the ABI versioning support in libc++ in http://reviews.llvm.org/D11740

Diff Detail

Repository
rL LLVM

Event Timeline

eugenis updated this revision to Diff 33257.Aug 26 2015, 3:14 PM
eugenis retitled this revision from to Extend linux header search to find libc++ headers in c++/vN for any N..
eugenis updated this object.
eugenis added reviewers: mclow.lists, EricWF, rsmith.
eugenis set the repository for this revision to rL LLVM.
eugenis added a subscriber: cfe-commits.
jroelofs added inline comments.
lib/Driver/ToolChains.cpp
3849

StringRef instead?

3876–3877

Kill the FIXME while you're here fixing what the FIXME complains about.

eugenis updated this revision to Diff 33259.Aug 26 2015, 3:31 PM
eugenis removed rL LLVM as the repository for this revision.
eugenis marked 2 inline comments as done.

ping
We will need this when libc++ is bumped to v2. There are no plans to do this AFAIK but the ABI version macros are in so it is possible and clang should be ready.

LGTM

lib/Driver/ToolChains.cpp
3859

Since you've got logic here to pick the newest headers, you should also have a tree that has both usr/include/c++/v1 and usr/include/c++/v2 to test that part of this change.

It's probably also a good idea to have a tree laid out as if libstdc++ and libc++ were both installed, i.e. both usr/include/c++/v1 and usr/include/c++/5.0 in it.

eugenis updated this revision to Diff 39587.Nov 6 2015, 1:49 PM
eugenis set the repository for this revision to rL LLVM.
eugenis marked an inline comment as done.
eugenis accepted this revision.Nov 9 2015, 1:13 PM
eugenis added a reviewer: eugenis.
This revision is now accepted and ready to land.Nov 9 2015, 1:13 PM
eugenis closed this revision.Nov 9 2015, 1:13 PM

r252514