I checked this patch on my own build on RHEL 6.
Please check it in if it's OK, because I don't have SVN write access.
Paths
| Differential D12220
[LLDB] Fix Clang-tidy misc-use-override warnings in source/Plugins/ABI, unify closing inclusion guards, protected members position AbandonedPublic Authored by Eugene.Zelenko on Aug 20 2015, 4:08 PM.
Details
Diff Detail Event TimelineEugene.Zelenko retitled this revision from to [LLDB] Fix Clang-tidy misc-use-override warnings in source/Plugins/ABI, unify closing inclusion guards, protected members position. Eugene.Zelenko updated this object. brucem edited edge metadata. Comment ActionsThis also has the whitespace changes and needs rebasing forward. (And a question for someone about the nature of one of the changes.)
This revision now requires changes to proceed.Oct 7 2015, 6:57 PM
Revision Contents
Diff 32764 source/Plugins/ABI/MacOSX-arm/ABIMacOSX_arm.h
source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.hsource/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.cpp
source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.h
source/Plugins/ABI/SysV-arm/ABISysV_arm.h
source/Plugins/ABI/SysV-arm64/ABISysV_arm64.h
source/Plugins/ABI/SysV-i386/ABISysV_i386.h
source/Plugins/ABI/SysV-mips/ABISysV_mips.h
source/Plugins/ABI/SysV-mips64/ABISysV_mips64.h
source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h
source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h
source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.h
|
@clayborg et al: Is this sort of change desired? (I lost track of whether or not these 2 constructs are the same in modern C++.)