This is an archive of the discontinued LLVM Phabricator instance.

[LLDB] Fix Clang-tidy misc-use-override warnings in source/Plugins/ABI, unify closing inclusion guards, protected members position
AbandonedPublic

Authored by Eugene.Zelenko on Aug 20 2015, 4:08 PM.

Details

Summary

I checked this patch on my own build on RHEL 6.

Please check it in if it's OK, because I don't have SVN write access.

Diff Detail

Event Timeline

Eugene.Zelenko retitled this revision from to [LLDB] Fix Clang-tidy misc-use-override warnings in source/Plugins/ABI, unify closing inclusion guards, protected members position.
Eugene.Zelenko updated this object.
Eugene.Zelenko added reviewers: labath, clayborg.
Eugene.Zelenko set the repository for this revision to rL LLVM.Sep 10 2015, 10:45 AM
Eugene.Zelenko added a subscriber: lldb-commits.
brucem requested changes to this revision.Oct 7 2015, 6:57 PM
brucem edited edge metadata.

This also has the whitespace changes and needs rebasing forward. (And a question for someone about the nature of one of the changes.)

source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.h
25

@clayborg et al: Is this sort of change desired? (I lost track of whether or not these 2 constructs are the same in modern C++.)

This revision now requires changes to proceed.Oct 7 2015, 6:57 PM
Eugene.Zelenko abandoned this revision.Oct 8 2015, 1:01 PM