Page MenuHomePhabricator

Understand absolute base addresses in ProcessGDBRemote::GetLoadedModuleList.
ClosedPublic

Authored by sas on Aug 20 2015, 11:50 AM.

Details

Summary

This is useful when dealing with Windows remote that use only the
qXfer:libraries command which returns absolute base addresses, as
opposed to qXfer:libraries-svr4 which returns relative offsets for
module bases.

Event Timeline

sas updated this revision to Diff 32720.Aug 20 2015, 11:50 AM
sas retitled this revision from to Understand absolute base addresses in ProcessGDBRemote::GetLoadedModuleList..
sas updated this object.
sas added reviewers: clayborg, zturner, ADodds.
sas added a subscriber: lldb-commits.

Looks good to me, but I don't know too much about the Windows stuff. I have a pending CL what will fix several issues related to absolute base addresses in the DynamicLoader. If it is something what is required on Windows side also I will try to upload it.

clayborg accepted this revision.Aug 20 2015, 12:47 PM
clayborg edited edge metadata.

Looks fine.

This revision is now accepted and ready to land.Aug 20 2015, 12:47 PM
sas added a comment.Aug 20 2015, 1:46 PM

Thanks for the reviews.

I'll take a look at your change when you upload it, Tamas. Do you think I can commit this in the meantime?

Yes, mine is effecting the ObjectFile plugins and the DynamicLoader plugins. I will try to upload it tomorrow

sas added a comment.Aug 20 2015, 3:07 PM

Sounds good. Thanks.

This revision was automatically updated to reflect the committed changes.