This is an archive of the discontinued LLVM Phabricator instance.

[SemaExpr] Re-enable missing assertion
ClosedPublic

Authored by davide on Aug 18 2015, 12:09 PM.

Details

Summary

This has been disabled for a long time, but:

  1. Initializers work (and apparently they're re reason why this was disabled).
  2. various tests happen to hit this code path and the invariant seems to be always verified.

I propose to add this back, it may be useful to catch mistakes.

Diff Detail

Event Timeline

davide updated this revision to Diff 32436.Aug 18 2015, 12:09 PM
davide retitled this revision from to [SemaExpr] Re-enable missing assertion .
davide updated this object.
davide added a reviewer: rsmith.
davide added a subscriber: cfe-commits.
davide added a subscriber: davide.Aug 18 2015, 1:05 PM

While at it, maybe the assertion can be modernized removing the != 0 part.

rsmith edited edge metadata.Aug 18 2015, 4:49 PM
rsmith added a subscriber: rsmith.

LGTM

davide accepted this revision.Aug 18 2015, 7:20 PM
davide added a reviewer: davide.
This revision is now accepted and ready to land.Aug 18 2015, 7:20 PM
davide closed this revision.Aug 18 2015, 7:23 PM