This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Refactoring add_compiler_rt functions for darwin runtimes.
ClosedPublic

Authored by beanz on Aug 18 2015, 9:59 AM.

Details

Summary

This patch consolidates add_compiler_rt_osx_static_runtime and add_compiler_rt_darwin_dynamic_runtime into a single new function add_compiler_rt_darwin_runtime.

Diff Detail

Event Timeline

beanz updated this revision to Diff 32421.Aug 18 2015, 9:59 AM
beanz retitled this revision from to [CMake] Refactoring add_compiler_rt functions for darwin runtimes..
beanz updated this object.
beanz added reviewers: filcab, samsonov, bogner.
beanz added a subscriber: llvm-commits.
beanz accepted this revision.Aug 18 2015, 10:32 AM
beanz added a reviewer: beanz.

Marking as accepted per bogner's response on llvm-commits.

This revision is now accepted and ready to land.Aug 18 2015, 10:32 AM
This revision was automatically updated to reflect the committed changes.
filcab added inline comments.Aug 18 2015, 11:10 AM
compiler-rt/trunk/cmake/Modules/AddCompilerRT.cmake
109 ↗(On Diff #32423)

If I pass SHARED *and* STATIC, I only get SHARED? Maybe an error would be useful, here (straight to error, since it's a developer problem (bad CMake call)).