Make @skipUnlessArch actually skip instead of XFAIL

[chaoren]

test/lldbtest.py

943

Is there a reason

return unittest2.skipUnless(getArchitecture() in archlist, ...)

is not sufficient?

Also, please add a doc string, like the other skip{If,Unless} methods.

[zturner]

test/lldbtest.py

943

getArchitecture() is a member of self, which is not defined here. TBH this stuff is beyond my Python level, I tried simpler versions but this is how I ultimately got it working after seeing what some of the other decorators did.

[chaoren]

test/lldbtest.py

943

Okay. I see what you mean. LGTM for now (if it works), I'll add a change later to unittest2.skip* to allow a callback that takes a test_item, instead of just a condition.

test/lldbtest.py

         return arch in self.getArchitecture()
     return expectedFailure(fn, bugnumber)
 
-def skipUnlessArch(arch):
-    def fn(self):
-        return not self.getArchitecture() in arch 
-    return expectedFailure(fn, None)
-
 def expectedFailurei386(bugnumber=None):
     return expectedFailureArch('i386', bugnumber)
 

     return unittest2.skipUnless(getHostPlatform() in oslist,
                                 "requires on of %s" % (", ".join(oslist)))
 
+def skipUnlessArch(archlist):
+    def myImpl(func):
+        if isinstance(func, type) and issubclass(func, unittest2.TestCase):
+            raise Exception("@skipUnlessArch can only be used to decorate a test method")
+
+        @wraps(func)
+        def wrapper(*args, **kwargs):
+            self = args[0]
+            if self.getArchitecture() not in archlist:
+                self.skipTest("skipping for architecture %s (requires one of %s)" % 
+                    (self.getArchitecture(), ", ".join(archlist)))
+            else:
+                func(*args, **kwargs)
+        return wrapper
+
+    return myImpl
+
 def skipIfPlatform(oslist):
     """Decorate the item to skip tests if running on one of the listed platforms."""
     return unittest2.skipIf(getPlatform() in oslist,