Logically Dead Code

[chakshugrover]

Summary

Removed Logically Dead Code

13698	  if (!II) {
13699	    Diag(DeclStart, diag::err_anonymous_property);
13700	    return nullptr;
13701	  }

As we have already handled the case for II being NULL. So now further we take the value of II to be non-NULL making this condition here essentially true

13770	  } else if (II) {
13771	    PushOnScopeChains(NewPD, S);
13772	  } else

and making this code logically dead

13772	  } else
13773	    Record->addDecl(NewPD);

[chakshugrover]

Gentle ping!

[vsk]

Good catch! LGTM.

lib/Sema/SemaDeclCXX.cpp

if (NewPD->isInvalidDecl())
     Record->setInvalidDecl();
 
   if (D.getDeclSpec().isModulePrivateSpecified())
     NewPD->setModulePrivate();
 
   if (NewPD->isInvalidDecl() && PrevDecl) {
     // Don't introduce NewFD into scope; there's already something
     // with the same name in the same scope.
-  } else if (II) {
-    PushOnScopeChains(NewPD, S);
-  } else
-    Record->addDecl(NewPD);
+  } else 
+    PushOnScopeChains(NewPD, S);
   
   return NewPD;
 }