Logically Dead Code

[chakshugrover]

Summary

Removed Logically Dead Code

3249	  if (ForClass)
3250	    return llvm::Constant::getNullValue(ObjCTypes.IvarListPtrTy);

As we have already handled the case for ForClass being non-zero. So now further we take the false branch and the value of ForClass is equal to 0. So there's no need for additionally checking it again, making this code logically dead

3280	  if (ForClass)
3281	    GV =
3282	        CreateMetadataVar("OBJC_CLASS_VARIABLES_" + ID->getName(), Init,
3283	                          "__OBJC,__class_vars,regular,no_dead_strip", 4, true);
3284	  else

[chakshugrover]

Gentle ping!

[vsk]

Thanks for the catch. LGTM.

lib/CodeGen/CGObjCMac.cpp

llvm::Constant *CGObjCMac::EmitIvarList(const ObjCImplementationDecl *ID,
   llvm::Constant *Values[2];
   Values[0] = llvm::ConstantInt::get(ObjCTypes.IntTy, Ivars.size());
   llvm::ArrayType *AT = llvm::ArrayType::get(ObjCTypes.IvarTy,
                                              Ivars.size());
   Values[1] = llvm::ConstantArray::get(AT, Ivars);
   llvm::Constant *Init = llvm::ConstantStruct::getAnon(Values);
 
   llvm::GlobalVariable *GV;
-  if (ForClass)
-    GV =
-        CreateMetadataVar("OBJC_CLASS_VARIABLES_" + ID->getName(), Init,
-                          "__OBJC,__class_vars,regular,no_dead_strip", 4, true);
-  else
-    GV = CreateMetadataVar("OBJC_INSTANCE_VARIABLES_" + ID->getName(), Init,
-                           "__OBJC,__instance_vars,regular,no_dead_strip", 4,
-                           true);
   return llvm::ConstantExpr::getBitCast(GV, ObjCTypes.IvarListPtrTy);
 }
 
 /*
   struct objc_method {
   SEL method_name;
   char *method_types;
   void *method;