This is an archive of the discontinued LLVM Phabricator instance.

Enable EliminateAvailableExternally pass in the LTO pipeline.
ClosedPublic

Authored by tejohnson on Aug 10 2015, 2:30 PM.

Details

Summary

For LTO we need to enable this pass in the LTO pipeline,
as it is skipped during the "-flto -c" compile step (when PrepareForLTO is
set).

Diff Detail

Repository
rL LLVM

Event Timeline

tejohnson updated this revision to Diff 31727.Aug 10 2015, 2:30 PM
tejohnson retitled this revision from to Enable EliminateAvailableExternally pass in the LTO pipeline..
tejohnson updated this object.
tejohnson added reviewers: rnk, dexonsmith.
tejohnson added a subscriber: llvm-commits.
rnk accepted this revision.Aug 10 2015, 2:40 PM
rnk edited edge metadata.

lgtm

lib/Transforms/IPO/PassManagerBuilder.cpp
559–564 ↗(On Diff #31727)

I think you can shorten this to something like:

// Drop bodies of available externally objects to improve GlobalDCE.
This revision is now accepted and ready to land.Aug 10 2015, 2:40 PM
tejohnson updated this revision to Diff 31816.Aug 11 2015, 7:30 AM
tejohnson edited edge metadata.
  • Update comments per review.
This revision was automatically updated to reflect the committed changes.