This is an archive of the discontinued LLVM Phabricator instance.

[libunwind] Remove unused includes
ClosedPublic

Authored by whitequark on Aug 10 2015, 1:07 AM.

Details

Summary

These include directives seem to be carried over from libc++abi. Nothing defined in them seems to be used and they do not break build of libunwind on any compiler/platform I tried. (Unlike #include <algorithm>, which is apparently necessary for static_assert on gcc.)

Diff Detail

Event Timeline

whitequark updated this revision to Diff 31637.Aug 10 2015, 1:07 AM
whitequark retitled this revision from to [libunwind] Remove unused includes.
whitequark updated this object.
whitequark added reviewers: kledzik, rengolin.
whitequark added a subscriber: llvm-commits.
emaste added a subscriber: emaste.Aug 13 2015, 12:55 PM

This looks like silly left-overs... LGTM, but I'd rather at least someone else would vouch for that, as I'm not building libc++abi that frequently.

logan accepted this revision.Aug 19 2015, 5:17 PM
logan added a reviewer: logan.
logan added a subscriber: logan.

LGTM. Tested on x86_64 and arm-linux-gnueabihf.

This revision is now accepted and ready to land.Aug 19 2015, 5:17 PM
EricWF edited edge metadata.Aug 26 2015, 11:40 AM

@whitequark Do you need somebody to commit this for you?

Missed the LGTM, sorry. Will commit the next time I'm near git-svn.