This is an archive of the discontinued LLVM Phabricator instance.

[Polly] Make ScopInfo handle PHI nodes in exit block
AbandonedPublic

Authored by Meinersbur on Aug 8 2015, 11:20 AM.

Details

Reviewers
grosser
Summary

after iterating over all blocks of the region, also iterate over the exit block which normally does not belong to the region. The exit block may contain PHI nodes that will later be moved into the region.

Such PHI nodes cannot yet occur without changes upstream (TempScopInfo, ScopDetection) which will follow.

Diff Detail

Event Timeline

Meinersbur updated this revision to Diff 31587.Aug 8 2015, 11:20 AM
Meinersbur retitled this revision from to Make ScopInfo handle PHI nodes in exit block.
Meinersbur updated this object.
Meinersbur added a reviewer: grosser.
Meinersbur added a project: Restricted Project.
Meinersbur added a subscriber: pollydev.
Meinersbur retitled this revision from Make ScopInfo handle PHI nodes in exit block to [Polly] Make ScopInfo handle PHI nodes in exit block.Aug 8 2015, 11:25 AM

I am unsure if I missed something but this looks to me like two code extractions into helper functions and hidden in line 1693ff some code that does create an extra statement. I do not mind the first part (extraction) but I have some comments regarding the second:

  1. Please commit them separately
  2. For the extra statement I think we need at least one test case as well as some motivation how this actually helps us.
  1. For the extra statement I think we need at least one test case as well as some motivation how this actually helps us.

This patch alone has no effect. See summary.

grosser accepted this revision.Aug 12 2015, 1:47 PM
grosser edited edge metadata.

LGTM. Please merge with other changes to ensure we get test coverage at the first commit.

This revision is now accepted and ready to land.Aug 12 2015, 1:47 PM
Meinersbur abandoned this revision.Aug 13 2015, 10:49 AM

Merged into D11869