This is an archive of the discontinued LLVM Phabricator instance.

CFI: Add diagnostic handler and tests for indirect call checker.
ClosedPublic

Authored by pcc on Aug 7 2015, 6:32 PM.

Diff Detail

Event Timeline

pcc updated this revision to Diff 31569.Aug 7 2015, 6:32 PM
pcc retitled this revision from to CFI: Add diagnostic handler and tests for indirect call checker..
pcc updated this object.
pcc added reviewers: kcc, samsonov.
pcc added a subscriber: llvm-commits.
samsonov added inline comments.Aug 10 2015, 1:31 PM
lib/ubsan/ubsan_handlers.cc
425

handleCFIBadIcall (for consistency)

428

Don't you need to call ignoreReport here to deduplicate reports?

test/cfi/bad-signature.c
21

You don't check for "f() defined here:" diagnostic note.

pcc updated this revision to Diff 31858.Aug 11 2015, 2:02 PM
  • Address review comments
samsonov accepted this revision.Aug 11 2015, 2:52 PM
samsonov edited edge metadata.

LGTM

This revision is now accepted and ready to land.Aug 11 2015, 2:52 PM
This revision was automatically updated to reflect the committed changes.