This is an archive of the discontinued LLVM Phabricator instance.

Differential D117196

[compiler-rt][RISCV] Implement __clear_cache() on ELF
AbandonedPublic

Authored by Jim on Jan 13 2022, 12:52 AM.

Details

Reviewers
luismarques
Summary

Implement __clear_cache() for RISC-V ELF. Just use fence.i like GCC.

Diff Detail

Event Timeline

Jim created this revision.Jan 13 2022, 12:52 AM
Herald added subscribers: VincentWu, luke957, achieveartificialintelligence and 11 others. · View Herald TranscriptJan 13 2022, 12:52 AM
Jim requested review of this revision.Jan 13 2022, 12:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 13 2022, 12:52 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Jim edited the summary of this revision. (Show Details)Jan 13 2022, 12:56 AM
Jim added a reviewer: luismarques.
Herald added a subscriber: PkmX. · View Herald TranscriptJan 13 2022, 12:56 AM
Harbormaster completed remote builds in B143096: Diff 399572.Jan 13 2022, 1:10 AM
luismarques added a comment.Jan 13 2022, 3:03 AM

Please see D92464 for a discussion about the issues with this.

Jim abandoned this revision.Jan 13 2022, 5:41 PM
In D117196#3240173, @luismarques wrote:

Please see D92464 for a discussion about the issues with this.

Oh. Thanks.

Revision Contents

PathSize
compiler-rt/
lib/
builtins/
2 lines

Diff 399572

compiler-rt/lib/builtins/clear_cache.c

Show First 20 Lines • Show All 167 Lines • ▼ Show 20 Lines#elif defined(__riscv) && defined(__linux__)
assert(start_reg == 0 && "Cache flush syscall failed."); assert(start_reg == 0 && "Cache flush syscall failed.");
#elif defined(__riscv) && defined(__OpenBSD__) #elif defined(__riscv) && defined(__OpenBSD__)
struct riscv_sync_icache_args arg; struct riscv_sync_icache_args arg;
arg.addr = (uintptr_t)start; arg.addr = (uintptr_t)start;
arg.len = (uintptr_t)end - (uintptr_t)start; arg.len = (uintptr_t)end - (uintptr_t)start;
sysarch(RISCV_SYNC_ICACHE, &arg); sysarch(RISCV_SYNC_ICACHE, &arg);
#elif defined(__riscv) && defined(__ELF__)
__asm__ volatile("fence.i");
#else #else
#if __APPLE__ #if __APPLE__
// On Darwin, sys_icache_invalidate() provides this functionality // On Darwin, sys_icache_invalidate() provides this functionality
sys_icache_invalidate(start, end - start); sys_icache_invalidate(start, end - start);
#elif defined(__ve__) #elif defined(__ve__)
__asm__ volatile("fencec 2"); __asm__ volatile("fencec 2");
#else #else
compilerrt_abort(); compilerrt_abort();
#endif #endif
#endif #endif
} }