This is an archive of the discontinued LLVM Phabricator instance.

[MachO] Replace macho-dump with llvm-readobj in tests
ClosedPublic

Authored by davide on Jul 28 2015, 12:21 PM.

Details

Summary

The main reason why I brought up this review is understanding if the format provided by llvm-readobj -r is good enough for us.
macho-dump just dumps the raw words for each reloc while readobj prints something more human readable after processing.
I personally like llvm-readobj format a lot better, but I would like to hear other opinions. An alternative would be that of introducing llvm-readobj --dump-raw-reloc-macho (maybe with a less cumbersome name), but I don't think it's really needed.

Diff Detail

Event Timeline

davide updated this revision to Diff 30843.Jul 28 2015, 12:21 PM
davide retitled this revision from to [MachO] Replace macho-dump with llvm-readobj in tests.
davide updated this object.
davide added reviewers: echristo, rafael, grosbach.
davide set the repository for this revision to rL LLVM.
davide added a subscriber: llvm-commits.
echristo accepted this revision.Jul 28 2015, 12:23 PM
echristo edited edge metadata.

LGTM.

-eric

This revision is now accepted and ready to land.Jul 28 2015, 12:23 PM
davide closed this revision.Jul 31 2015, 9:52 PM

This was committed a while ago.