[libcxxabi] Add -funwind-tables to the test compilation options.

[dsanders]

Summary

backtrace_test.pass.cpp depends on unwind tables. These are generated by
-funwind-tables which is the default for x86 but not for other targets.

Thanks to Nitesh Jain for helping to narrow this down.

[jroelofs]

LGTM... Thanks!

[jroelofs]

CC-ing cfe-commits (which is where patches to libcxxabi should go).

[hans]

Should I interpret me being cc'd as a merge request? :-)

[dsanders]

Thanks

CC-ing cfe-commits (which is where patches to libcxxabi should go).

Sorry. I sent the other libcxxabi patch to the right list but it looks like habit won this time. Thanks for correcting this.

Should I interpret me being cc'd as a merge request? :-)

Sorry, I forgot to say which ticket it fixes on the review but I remembered for the commit (r243296). It fixes PR24148.
I'm not sure who the code-owner for libcxxabi is though. I could only find libcxx in CODE_OWNERS.txt

[dsanders]

Should I interpret me being cc'd as a merge request? :-)

Sorry, I forgot to say which ticket it fixes on the review but I remembered for the commit (r243296). It fixes PR24148.
I'm not sure who the code-owner for libcxxabi is though. I could only find libcxx in CODE_OWNERS.txt

There should have been a 'yes' in that reply :-). Clearly I'm trying to do too many things at once.

[dsanders]

This is committed to trunk but not merged yet since the person we believe to be the code owner hasn't responded yet.

Hans: Are you willing to approve the merge?

[dsanders]

I've just noticed Marshal isn't CC'd. That might explain the lack of approval for the merge :-). Added him.

[mclow.lists]

I'm fine with this.

[dsanders]

Thanks. Merged to 3.7 branch in r243649.

test/libcxxabi/test/config.py

def configure_src_root(self):
             os.path.join(self.libcxxabi_src_root, '/../libcxx'))
 
     def configure_obj_root(self):
         self.libcxxabi_obj_root = self.get_lit_conf('libcxxabi_obj_root')
         super(Configuration, self).configure_obj_root()
 
     def configure_compile_flags(self):
         self.cxx.compile_flags += ['-DLIBCXXABI_NO_TIMER']
+        self.cxx.compile_flags += ['-funwind-tables']
         super(Configuration, self).configure_compile_flags()
 
     def configure_compile_flags_header_includes(self):
         cxx_headers = self.get_lit_conf(
             'cxx_headers',
             os.path.join(self.libcxx_src_root, '/include'))
         if not os.path.isdir(cxx_headers):
             self.lit_config.fatal("cxx_headers='%s' is not a directory."