This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Enable fixed function ABI by default
ClosedPublic

Authored by arsenm on Dec 4 2021, 6:47 AM.

Details

Reviewers
ronlieb
JonChesterfield
Group Reviewers
Restricted Project
Summary

Code using indirect calls is broken without this, and there isn't
really much value in supporting the old attempt to vary the argument
placement based on uses. This resulted in more argument shuffling code
anyway.

Also have the option stop implying all inputs need to be passed. This
will no rely on the amdgpu-no-* attributes to avoid passing
unnecessary values.

Diff Detail

Event Timeline

arsenm created this revision.Dec 4 2021, 6:47 AM
arsenm requested review of this revision.Dec 4 2021, 6:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 4 2021, 6:47 AM
Herald added a subscriber: wdng. · View Herald Transcript
ronlieb accepted this revision.Dec 4 2021, 7:13 AM
This revision is now accepted and ready to land.Dec 4 2021, 7:13 AM
JonChesterfield accepted this revision.Dec 4 2021, 7:18 AM
JonChesterfield added a subscriber: JonChesterfield.

LGTM, thanks!