Change Socket::Read / Socket::Write to log to LOG_COMMUNICATION instead of LOG_HOST

[jasonmolenda]

Summary

I'm adding some new host logging to help diagnose problems of finding executable files or dSYMs, Greg suggested we should add it to the Host log channel. Currently Socket::Read and Socket::Write are logging to Host which is super verbose. He suggests that we should switch these over the Communication log channel instead. Some of Socket.cpp is logging to LOG_CONNECTION already. Zachary, any opinion on this? I think you touched this most recently. Not sure if you're using this logging yourself.

[zturner]

Seems reasonable. lgtm

[jasonmolenda]

Sending source/Host/common/Socket.cpp
Transmitting file data .
Committed revision 243175.

source/Host/common/Socket.cpp

     NativeSocket sock = kInvalidSocketValue;
     Error error;
 
-    Log *log(lldb_private::GetLogIfAnyCategoriesSet (LIBLLDB_LOG_HOST));
+    Log *log(lldb_private::GetLogIfAnyCategoriesSet (LIBLLDB_LOG_COMMUNICATION));
     if (log)
         log->Printf ("Socket::TcpConnect (host/port = %s)", host_and_port.data());
 

     else
         num_bytes = bytes_received;
 
-    Log *log(lldb_private::GetLogIfAnyCategoriesSet (LIBLLDB_LOG_HOST | LIBLLDB_LOG_COMMUNICATION)); 
+    Log *log(lldb_private::GetLogIfAnyCategoriesSet (LIBLLDB_LOG_COMMUNICATION)); 
     if (log)
     {
         log->Printf ("%p Socket::Read() (socket = %" PRIu64 ", src = %p, src_len = %" PRIu64 ", flags = 0) => %" PRIi64 " (error = %s)",

     else
         num_bytes = bytes_sent;
 
-    Log *log(lldb_private::GetLogIfAnyCategoriesSet (LIBLLDB_LOG_HOST));
+    Log *log(lldb_private::GetLogIfAnyCategoriesSet (LIBLLDB_LOG_COMMUNICATION));
     if (log)
     {
         log->Printf ("%p Socket::Write() (socket = %" PRIu64 ", src = %p, src_len = %" PRIu64 ", flags = 0) => %" PRIi64 " (error = %s)",