This is an archive of the discontinued LLVM Phabricator instance.

LibompMicroTests.cmake: Invoke 'test' instead of using '[ x -eq y ]'
ClosedPublic

Authored by hans on Jul 24 2015, 1:27 PM.

Details

Summary

I was getting this cmake error on Mac OS X:

CMake Error: Error in cmake code at
/tmp/openmp/runtime/cmake/LibompMicroTests.cmake:140:
Parse error.  Function missing ending ")".  Instead found bad character with text "[".

Perhaps invoking 'test' is less confusing for cmake.

Diff Detail

Event Timeline

hans updated this revision to Diff 30599.Jul 24 2015, 1:27 PM
hans retitled this revision from to LibompMicroTests.cmake: Invoke 'test' instead of using '[ x -eq y ]'.
hans updated this object.
hans added a reviewer: jlpeyton.
hans added a subscriber: openmp-commits.
jlpeyton accepted this revision.Jul 24 2015, 1:50 PM
jlpeyton edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Jul 24 2015, 1:50 PM
This revision was automatically updated to reflect the committed changes.