Add a basic to use for when building for cygwin on x86_64
Details
Diff Detail
Event Timeline
Hi Yaron,
I'm not quite sure how you dealt with the blank namespace the last time.
I assume this is okay as it is between one?
All these classes are already inside a bug anonymous namespace and so is the new one you add, this is OK.
Currently it seems you only have 32bits
I assume it used a generic x86_64 target but now that you set MSVC at the default it probably uses that which isn't good for cygwin64
FYI, I tried, in past, to build cyg64. https://github.com/chapuni/llvm-project/commits/cygwin64/trunk
Yes I see this commit https://github.com/chapuni/llvm-project/commit/9a1fcf7d0a897ce82b7b1a81431e04304f116d51
Is quite similar to what I have submitted. :)
I'm just 2 years behind
Yaron
There are other considerations such as the include dirs having i686 hard coded.
I plan to add a driver to Cygwin very similar to the MINGW Driver to deal with these kinds of issues.
Actually having the target is a good start though :)
LGTM after fixing the comment.
tools/clang/lib/Basic/Targets.cpp | ||
---|---|---|
4005 | This should be X86_64TargetInfo::getTargetDefines(Opts, Builder); |
This should be X86_64TargetInfo::getTargetDefines(Opts, Builder);