Page MenuHomePhabricator

Detect if necessary to build inferior with -pie for Android.
ClosedPublic

Authored by chaoren on Jul 17 2015, 1:17 PM.

Details

Summary
  • Add target_is_android check (with cached results).
  • Make android_device_api also cache results.
  • Also removes the need to pass --env OS=Android when testing against Android.

Diff Detail

Repository
rL LLVM

Event Timeline

chaoren retitled this revision from to Detect if necessary to build inferior with -pie for Android..
chaoren updated this object.
chaoren added a subscriber: lldb-commits.
clayborg accepted this revision.Jul 17 2015, 1:22 PM
clayborg edited edge metadata.

Looks fine.

This revision is now accepted and ready to land.Jul 17 2015, 1:22 PM
danalbert added inline comments.Jul 17 2015, 1:23 PM
test/lldbtest.py
1993 ↗(On Diff #30027)

I thought this was >= 16. I don't think we supported it in 15.

danalbert requested changes to this revision.Jul 17 2015, 1:25 PM
danalbert added a reviewer: danalbert.
danalbert added inline comments.
test/lldbtest.py
1993 ↗(On Diff #30027)
This revision now requires changes to proceed.Jul 17 2015, 1:25 PM

Ah okay, we'd need to update some comments in Android.cmake too then.

chaoren edited edge metadata.
  • API 16 is the first to support PIE, not 14.
danalbert accepted this revision.Jul 17 2015, 1:32 PM
danalbert edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Jul 17 2015, 1:32 PM
chaoren edited edge metadata.

Minor fixup.

This revision was automatically updated to reflect the committed changes.