Page MenuHomePhabricator

Fix build errors on older versions of gcc
ClosedPublic

Authored by omjavaid on Jul 16 2015, 1:49 AM.

Details

Summary

This patch fixes some build errors while building with gcc 4.7.x or below.

Errors occured while building with arm-linux-gnueabi-gcc which is still using gcc 4.6 release.

Diff Detail

Event Timeline

omjavaid updated this revision to Diff 29874.Jul 16 2015, 1:49 AM
omjavaid retitled this revision from to Fix build errors on older versions of gcc.
omjavaid updated this object.
omjavaid added reviewers: tberghammer, clayborg.
omjavaid added a subscriber: lldb-commits.
tberghammer accepted this revision.Jul 16 2015, 5:46 AM
tberghammer edited edge metadata.

Looks good to me, but I am not sure if gcc-4.6 supports all c++11 feature we are using and LLVM officially supports gcc-4.7+, so you might run into other issues also using gcc-4.6. If possible, I suggest to try to upgrade your compiler to avoid further issues.

This revision is now accepted and ready to land.Jul 16 2015, 5:46 AM
clayborg accepted this revision.Jul 16 2015, 10:24 AM
clayborg edited edge metadata.

As long as there are no other changes and LLDB actually does build and run using a gcc 4.6 built binary, go ahead and check this in. If anything still fails and gcc 4.6 can compile everything leave it out.

omjavaid closed this revision.Feb 9 2016, 1:08 AM