Page MenuHomePhabricator

[Makefiles] Align library names with CMake build
ClosedPublic

Authored by loladiro on Jul 13 2015, 12:36 PM.

Details

Summary

This aligns the library names used by the Makefile build to be the same as those create by the CMake build to make switching between the two easier. The only major difficulty was lldbHost which was one library in the CMake system and several in the Makefile system. Most of the other changes are trivial renames.

Diff Detail

Repository
rL LLVM

Event Timeline

loladiro updated this revision to Diff 29594.Jul 13 2015, 12:36 PM
loladiro retitled this revision from to [Makefiles] Align library names with CMake build.
loladiro updated this object.
loladiro added a reviewer: labath.
loladiro set the repository for this revision to rL LLVM.
loladiro added a subscriber: lldb-commits.
labath edited edge metadata.Jul 14 2015, 1:49 AM

Looks simple enough. I just have one question below.

Also, I don't feel entirely comfortable reviewing makefile changes as I don't use that build on a regular basis. If there is someone here who uses makefile builds and would like to take charge of this (and future) changes, then please step in.

source/Host/Makefile
28 ↗(On Diff #29594)

Why are some of these using $(eval) and others $(eval $(call)) syntax? If there is no difference, we should unify them. If there is, let's put a comment explaining why.

loladiro updated this revision to Diff 29690.Jul 14 2015, 11:39 AM
loladiro edited edge metadata.

Updated to consistently use eval call everywhere. Thanks for catching that @labath.

labath accepted this revision.Jul 14 2015, 1:16 PM
labath edited edge metadata.

lgtm

This revision is now accepted and ready to land.Jul 14 2015, 1:16 PM
This revision was automatically updated to reflect the committed changes.