This is an archive of the discontinued LLVM Phabricator instance.

Support setting ARM dynamic linker name based on hard-float ABI being specified on compiler commandline
ClosedPublic

Authored by raj.khem on Jul 10 2015, 3:49 PM.

Details

Reviewers
rengolin
Summary

Currently trigger to select hard-float linker is only based of -gnueabihf
appearing in target triplet, but we should also select it when hardfloat
is requested via cmdline

Diff Detail

Event Timeline

raj.khem updated this revision to Diff 29500.Jul 10 2015, 3:49 PM
raj.khem retitled this revision from to Support setting ARM dynamic linker name based on hard-float ABI being specified on compiler commandline .
raj.khem updated this object.
raj.khem updated this object.Jul 10 2015, 3:52 PM
raj.khem updated this object.

I think this change makes sense. Please add a test without "gnueabihf" and with -mfloat-abi=hard on test/Driver/linux-ld.c.

Also, please use "diff -U999" when submitting patches to Phabricator, so we can see the context.

cheers,
--renato

raj.khem updated this revision to Diff 29753.Jul 14 2015, 9:57 PM

Create a test-case as suggested

rengolin accepted this revision.Jul 15 2015, 10:55 AM
rengolin added a reviewer: rengolin.

LGTM, thanks!

This revision is now accepted and ready to land.Jul 15 2015, 10:55 AM

Can we pull it into branch_37 as well please ?

You have to send an email to Tom Stellard, copying the list, with the commit in question.

Hi Renato,

This patch is still not applied. is there anything needed from my side ?

rengolin closed this revision.Jul 27 2015, 2:58 AM

Sorry for the delay, committed in r243262. I'll apply it to 3.7.0.