Currently this hits an assert that extload should
always be supported, which assumes integer extloads.
This moves a hack out of SI's argument lowering and
is covered by existing tests.
Paths
| Differential D11081
SelectionDAG: Support Expand of f16 extloads
ClosedPublic Authored by arsenm on Jul 9 2015, 1:06 PM.
Details
Summary Currently this hits an assert that extload should This moves a hack out of SI's argument lowering and
Diff Detail Event Timelinearsenm updated this object. Comment Actions I'll admit I'm not sure I understand what the test does (%arg is loaded?), but the code seems reasonable.
This revision is now accepted and ready to land.Aug 24 2015, 2:15 PM Comment Actions
Yes, kernel arguments are lowered as loads
Comment Actions LGTM, with some documentation for EVT::changeTypeToInteger. Thanks!
Revision Contents
Diff 33018 include/llvm/CodeGen/ValueTypes.h
lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
lib/IR/ValueTypes.cpp
lib/Target/AMDGPU/SIISelLowering.cpp
test/CodeGen/AMDGPU/half.ll
|
A short comment would be appreciated!