This change is part of a series of commits dedicated to have a single
DataLayout during compilation by using always the one owned by the
module.
Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
Update taking WebAssembly backend into account (the only experimental one AFAIK).
Also move DL as first parameter for consistency with all the other changes
Comment Actions
One inline question, LGTM otherwise though.
-eric
lib/CodeGen/AsmPrinter/AsmPrinter.cpp | ||
---|---|---|
140 | Is this going to have problems when you don't have a module (ala some of the other uses?). |
lib/CodeGen/AsmPrinter/AsmPrinter.cpp | ||
---|---|---|
140 | They never call this method (if they do, they're doomed). |
Comment Actions
One small inline request then go for it. We can look at refactors later.
-eric
lib/CodeGen/AsmPrinter/AsmPrinter.cpp | ||
---|---|---|
140 | Let's grab an assert for MMI to make it clear if something does manage to call it what happened. |
Is this going to have problems when you don't have a module (ala some of the other uses?).