This is an archive of the discontinued LLVM Phabricator instance.

Make TargetLowering::getShiftAmountTy() taking DataLayout as an argument
ClosedPublic

Authored by mehdi_amini on Jul 8 2015, 12:17 PM.

Details

Summary

This change is part of a series of commits dedicated to have a single
DataLayout during compilation by using always the one owned by the
module.

Diff Detail

Event Timeline

mehdi_amini retitled this revision from to Make TargetLowering::getShiftAmountTy() taking DataLayout as an argument.
mehdi_amini updated this object.
mehdi_amini added a reviewer: echristo.
echristo accepted this revision.Jul 8 2015, 4:03 PM
echristo edited edge metadata.

LGTM, wish we could get rid of that use...

-eric

include/llvm/Target/TargetLowering.h
174

Can you make sure the position of the DataLayout argument is consistent while you do this? (See above with getPointerTy).

This revision is now accepted and ready to land.Jul 8 2015, 4:03 PM
mehdi_amini added inline comments.Jul 8 2015, 5:32 PM
include/llvm/Target/TargetLowering.h
174

Sure!

Doing it I realized that the other parameter (EVT LHSTy) is never used, should I remove it?

echristo added inline comments.Jul 8 2015, 5:39 PM
include/llvm/Target/TargetLowering.h
174

Yep!