This is an archive of the discontinued LLVM Phabricator instance.

Make TargetTransformInfo keeping a reference to the Module DataLayout DataLayout is no longer optional. It was initialized with or without a DataLayout, and the DataLayout when supplied could have been the one from the TargetMachine.
ClosedPublic

Authored by mehdi_amini on Jul 7 2015, 5:51 PM.

Details

Summary

This change is part of a series of commits dedicated to have a single
DataLayout during compilation by using always the one owned by the
module.

Diff Detail

Event Timeline

mehdi_amini updated this revision to Diff 29228.Jul 7 2015, 5:51 PM
mehdi_amini retitled this revision from to Make TargetTransformInfo keeping a reference to the Module DataLayout DataLayout is no longer optional. It was initialized with or without a DataLayout, and the DataLayout when supplied could have been the one from the TargetMachine..
mehdi_amini updated this object.
mehdi_amini added a reviewer: echristo.
echristo accepted this revision.Jul 8 2015, 3:18 PM
echristo edited edge metadata.

One inline comment that can be fixed in a follow up patch (preapproved :)

Thanks!

-eric

lib/Target/AArch64/AArch64TargetTransformInfo.h
53

The TargetMachine class member is unused.

This revision is now accepted and ready to land.Jul 8 2015, 3:18 PM