This is an archive of the discontinued LLVM Phabricator instance.

Redirect DataLayout from TargetMachine to Module in SelectionDAG
ClosedPublic

Authored by mehdi_amini on Jul 7 2015, 9:44 AM.

Details

Summary

SelectionDAG itself is not invoking directly the DataLayout in the
TargetMachine, but the "TargetLowering" class is still using it. I'll
address it in a following commit.

This change is part of a series of commits dedicated to have a single
DataLayout during compilation by using always the one owned by the
module.

Diff Detail

Event Timeline

mehdi_amini updated this revision to Diff 29186.Jul 7 2015, 9:44 AM
mehdi_amini retitled this revision from to Redirect DataLayout from TargetMachine to Module in SelectionDAG.
mehdi_amini updated this object.
mehdi_amini added a reviewer: echristo.
mehdi_amini added a subscriber: llvm-commits.
mehdi_amini set the repository for this revision to rL LLVM.Jul 7 2015, 10:23 AM
mehdi_amini added subscribers: yaron.keren, rafael.
echristo accepted this revision.Jul 7 2015, 10:29 AM
echristo edited edge metadata.

One inline comment otherwise LGTM.

-eric

lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
6720

You can access the DAG directly here (as the code below shows). I don't mind an accessor, but cleaning that up should be a separate patch :)

This revision is now accepted and ready to land.Jul 7 2015, 10:29 AM