This is an archive of the discontinued LLVM Phabricator instance.

Redirect DataLayout from TargetMachine to Module in FastISel
ClosedPublic

Authored by mehdi_amini on Jul 6 2015, 10:57 PM.

Details

Summary

This change is part of a series of commits dedicated to have a single
DataLayout during compilation by using always the one owned by the
module.

Diff Detail

Event Timeline

mehdi_amini retitled this revision from to Redirect DataLayout from TargetMachine to Module in FastISel.
mehdi_amini updated this object.
mehdi_amini added a reviewer: echristo.
mehdi_amini added a subscriber: llvm-commits.
mehdi_amini set the repository for this revision to rL LLVM.Jul 7 2015, 10:21 AM
mehdi_amini edited subscribers, added: rafael; removed: rafael.espindola.
echristo edited edge metadata.Jul 7 2015, 10:35 AM

You could just cache it from the MachineFunction on initialization?

-eric

mehdi_amini edited edge metadata.

Caching is obviously a far better solution according to the size of the diff...

It show how worthwhile it is to split a large diff in small pieces :)

echristo accepted this revision.Jul 7 2015, 11:38 AM
echristo edited edge metadata.

Yep. :)

LGTM.

-eric

This revision is now accepted and ready to land.Jul 7 2015, 11:38 AM