This is an archive of the discontinued LLVM Phabricator instance.

Add missing builtins to the PPC back end for ABI compliance (vol. 3)
ClosedPublic

Authored by nemanjai on Jul 6 2015, 2:00 PM.

Details

Summary

This patch corresponds to review:
http://reviews.llvm.org/D10972

Back end portion of the third round of additions to altivec.h.

Diff Detail

Repository
rL LLVM

Event Timeline

nemanjai updated this revision to Diff 29125.Jul 6 2015, 2:00 PM
nemanjai retitled this revision from to Add missing builtins to the PPC back end for ABI compliance (vol. 3).
nemanjai updated this object.
nemanjai set the repository for this revision to rL LLVM.
nemanjai added a subscriber: llvm-commits.
hfinkel added inline comments.Jul 6 2015, 2:04 PM
lib/Target/PowerPC/PPCInstrVSX.td
1175

Please put this pattern with the other similar ones (around like 1000 it seems).

wschmidt edited edge metadata.Jul 8 2015, 12:28 PM

No further comments from me.

nemanjai added inline comments.Jul 9 2015, 6:51 AM
lib/Target/PowerPC/PPCInstrVSX.td
1175

I can put it closer to those, but this one needs the definition of XXLEQV and requires HasP8Vector.

@hfinkel Hal, could you please comment as to where you would like me to put the pattern. With the other ones (around line 1000) isn't really an option since it would be before the definition of the instruction that it uses. I can move ALL the patern fragments into one section below the definition of the instructions (keeping the correct predicates with each group).
If you actually don't want me to move it, can you please approve the changeset?
@wschmidt Bill, I can't commit D10972 without committing this. I'll get both of them in once this one is approved.

hfinkel accepted this revision.Jul 10 2015, 2:47 AM
hfinkel edited edge metadata.
hfinkel added inline comments.
lib/Target/PowerPC/PPCInstrVSX.td
1175

We should talk about how to best organize these files, because the scheme that existed previously has now been disrupted somewhat (not obviously in a bad way, but different from what we had before).

Please just move this to after where XXLEQV and XXLNAND are defined for now.

LGTM.

This revision is now accepted and ready to land.Jul 10 2015, 2:47 AM
nemanjai closed this revision.Jul 10 2015, 5:38 AM

Committed revision 241900.