This is an archive of the discontinued LLVM Phabricator instance.

[llvm-shlib] Fix the i686 MSVC triple check for listing symbols to export in LLVM-C.dll
ClosedPublic

Authored by mstorsjo on Sep 9 2021, 1:44 AM.

Details

Summary

https://reviews.llvm.org/D47381 / eb46c95c3e7aeba4d183ca614fe238067eddf97f
changed the triples set up by GetHostTriple.cmake without changing
the corresponding condition in llvm-shlib.

Since then, the 32 bit x86 build of LLVM-C.dll has contained no
exported symbols at all.

Diff Detail

Event Timeline

mstorsjo created this revision.Sep 9 2021, 1:44 AM
mstorsjo requested review of this revision.Sep 9 2021, 1:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 9 2021, 1:44 AM
mstorsjo added inline comments.Sep 9 2021, 1:50 AM
llvm/tools/llvm-shlib/CMakeLists.txt
127

I guess one could try to generalize this into matching i*86-*win* or something like that too...

phosek accepted this revision.Sep 10 2021, 10:42 AM

LGTM

llvm/tools/llvm-shlib/CMakeLists.txt
127

That might be better to handle all different variations of the triple.

This revision is now accepted and ready to land.Sep 10 2021, 10:42 AM
mstorsjo updated this revision to Diff 372012.Sep 10 2021, 2:29 PM

Generalized the condition to a regex.