This is an archive of the discontinued LLVM Phabricator instance.

Log to the right stream in DwarfTransformer::handleDie().
ClosedPublic

Authored by clayborg on Sep 7 2021, 4:12 PM.

Details

Summary

Since we might end up using multiple threads when logging information in the DWARFTransformer, the handleDie() method must use the supplied stream named "OS" when logging warnings and errors. When we use multiple threads, we log to a thread specific stream buffer and then use a mutex to ensure our output doesn't overlap when we emit warnings and errors after a thread is done.

Diff Detail

Event Timeline

clayborg created this revision.Sep 7 2021, 4:12 PM
clayborg requested review of this revision.Sep 7 2021, 4:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 7 2021, 4:12 PM
wallace accepted this revision.Sep 8 2021, 11:37 AM

makes sense!

This revision is now accepted and ready to land.Sep 8 2021, 11:37 AM
This revision was automatically updated to reflect the committed changes.