clang-format: Treat 'operator new' as function name.

[strager]

Summary

'operator new' was not being treated as a function name in
one case, so AlwaysBreakAfterDeclarationReturnType and
AlwaysBreakAfterDefinitionReturnType never triggered. This
bug affected other operators as well.

Depends on D10370.

[poiru]

lib/Format/TokenAnnotator.cpp

1543

This will (incorrectly) turn code like:

A& A::operator=(const A&) {
  return *this;
}

into:

A& A::
operator=(const A&) {
  return *this;
}

[strager]

lib/Format/TokenAnnotator.cpp

1543

Cool. I'll add tests and figure something out.

[poiru]

FYI, D11177 takes care of this.

lib/Format/TokenAnnotator.cpp

if (Current->is(TT_LineComment)) {
                spaceRequiredBefore(Line, *Current)) {
       Current->SpacesRequiredBefore = 1;
     }
 
     Current->MustBreakBefore =
         Current->MustBreakBefore || mustBreakBefore(Line, *Current);
 
     if (!Current->MustBreakBefore && InFunctionDecl &&
-        Current->is(TT_FunctionDeclarationName)) {
+        Current->isOneOf(tok::kw_operator, TT_FunctionDeclarationName)) {
       // FIXME: Line.Last points to other characters than tok::semi
       // and tok::lbrace.
       bool IsDefinition = !Line.Last->isOneOf(tok::semi, tok::comment);
       FormatStyle::ReturnTypeBreakingStyle BreakStyle =
           IsDefinition ? Style.AlwaysBreakAfterDefinitionReturnType
                        : Style.AlwaysBreakAfterDeclarationReturnType;
       if ((BreakStyle == FormatStyle::DRTBS_All ||
            (BreakStyle == FormatStyle::DRTBS_TopLevel && Line.Level == 0)))

unittests/Format/FormatTest.cpp

verifyFormat("const char *f(void) { return \"\"; }\n"
                "const char *\n"
                "bar(void);\n",
                Style);
   verifyFormat("template <class T> T *f(T &c) { return NULL; }\n"
                "template <class T>\n"
                "T *\n"
                "f(T &c);\n",
                Style);
+  verifyFormat("void *\n"
+               "operator new(std::size_t);",
+               Style);
+  verifyFormat("void *operator new(std::size_t) {}",
+               Style);
   Style.BreakBeforeBraces = FormatStyle::BS_Stroustrup;
   verifyFormat("const char *f(void) { return \"\"; }\n"
                "const char *\n"
                "bar(void);\n",
                Style);
   verifyFormat("template <class T> T *f(T &c) { return NULL; }\n"
                "template <class T>\n"
                "T *\n"
verifyFormat("const char *\n"
                Style);
   verifyFormat("template <class T>\n"
                "T *\n"
                "f(T &c) {\n" // Break here.
                "  return NULL;\n"
                "}\n"
                "template <class T> T *f(T &c);\n", // No break here.
                Style);
+  verifyFormat("void *operator new(std::size_t);", // No break here.
+               Style);
+  verifyFormat("void *\n"
+               "operator new(std::size_t) {}",
+               Style);
   Style.BreakBeforeBraces = FormatStyle::BS_Stroustrup;
   verifyFormat("const char *\n"
                "f(void)\n" // Break here.
                "{\n"
                "  return \"\";\n"
                "}\n"
                "const char *bar(void);\n", // No break here.
                Style);