This is an archive of the discontinued LLVM Phabricator instance.

Remove DataLayout access from the TargetMachine, redirect to the Module
ClosedPublic

Authored by mehdi_amini on Jun 29 2015, 4:30 PM.

Details

Reviewers
echristo
Summary

This is a crude "quick" tentative to remove access to the DataLayout in the TargetMachine.

Diff Detail

Repository
rL LLVM

Event Timeline

mehdi_amini retitled this revision from to Remove DataLayout access from the TargetMachine, redirect to the Module .
mehdi_amini updated this object.
mehdi_amini edited the test plan for this revision. (Show Details)
mehdi_amini added a reviewer: echristo.
mehdi_amini set the repository for this revision to rL LLVM.
mehdi_amini added a subscriber: Unknown Object (MLST).
rafael added inline comments.
include/llvm/Analysis/TargetTransformInfo.h
680

Changes like this make the patch harder to read. Can you git-clang-format it?

mehdi_amini added inline comments.Jun 29 2015, 5:06 PM
include/llvm/Analysis/TargetTransformInfo.h
680

I clang-formatted the patch, I assume this is why this particular line is changed (the original line was not clang-formatted).

Now there is no reason that git clang-format would create a separate hunk, so I probably had to touch it in an intermediate version.

echristo accepted this revision.Jul 6 2015, 9:56 AM
echristo edited edge metadata.

This works for me. If you can split out some of the changes into smaller bits that'd be great (the Mangler & -> const Mangler & is the one I noticed).

Thanks for doing this!

-eric

This revision is now accepted and ready to land.Jul 6 2015, 9:56 AM

Correction: this diff didn't land but was split multiple small patches.