This is an archive of the discontinued LLVM Phabricator instance.

Ignore "push/pop {sp}" in emulation based unwinding
ClosedPublic

Authored by tberghammer on Jun 29 2015, 8:39 AM.

Details

Summary

Ignore "push/pop {sp}" in emulation based unwinding

These instructions confusing the unwind code because in case of a
push it assumes that the original value of a register is pushed to
the stack what is not necessarily true in case of SP. The same is
true for the pop (in the opposite way).

Diff Detail

Event Timeline

tberghammer retitled this revision from to Ignore "push/pop {sp}" in emulation based unwinding.
tberghammer updated this object.
tberghammer edited the test plan for this revision. (Show Details)
tberghammer added a reviewer: jasonmolenda.
tberghammer added a subscriber: Unknown Object (MLST).
jasonmolenda accepted this revision.Jun 29 2015, 10:39 PM
jasonmolenda edited edge metadata.

Looks good to me.

This revision is now accepted and ready to land.Jun 29 2015, 10:39 PM
This revision was automatically updated to reflect the committed changes.