This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/SI: Add hsa code object directives
ClosedPublic

Authored by tstellarAMD on Jun 25 2015, 7:21 PM.

Diff Detail

Event Timeline

tstellarAMD retitled this revision from to AMDGPU/SI: Add hsa code object directives.
tstellarAMD updated this object.
tstellarAMD edited the test plan for this revision. (Show Details)
tstellarAMD added a reviewer: arsenm.
tstellarAMD added a subscriber: Unknown Object (MLST).
arsenm accepted this revision.Jun 25 2015, 7:58 PM
arsenm edited edge metadata.

LGTM

lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp
71–72

You can construct it directly
StringRef Name("AMD", 4);

96

Again

This revision is now accepted and ready to land.Jun 25 2015, 7:58 PM
lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp
71–72

I need to emit the NULL byte at the end, and the NULL byte won't be emitted if I construct it directly, because the StringRef will have length of 3.

arsenm added inline comments.Jun 26 2015, 8:20 AM
lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp
71–72

You can still directly construct it with the size

This revision was automatically updated to reflect the committed changes.