Add const versions of SBFrame::GetFunctionName and SBFrame::IsInlined.

[ovyalov]

Summary

Add const versions of SBFrame::GetFunctionName and SBFrame::IsInlined.

[jingham]

That seems fine.

Jim

[labath]

lgtm. Potentially we can leave a note to the future maintainer to remove the non-const versions, when/if we decide to make a breaking API change.

[ovyalov]

In D10711#194393, @labath wrote:

lgtm. Potentially we can leave a note to the future maintainer to remove the non-const versions, when/if we decide to make a breaking API change.

Let's keep this idea about removing non-const version in mind - I didn't put it in code since don't want it to be lost in one of multiple API headers.
We may add README.txt to include/lldb/API to cover maintenance details.

[ovyalov]

AFFECTED FILES

/lldb/trunk/include/lldb/API/SBFrame.h
/lldb/trunk/scripts/interface/SBFrame.i
/lldb/trunk/source/API/SBFrame.cpp

USERS

ovyalov (Author)

http://reviews.llvm.org/rL240660

include/lldb/API/SBFrame.h

public:
     /// - the name of the concrete function (if there is one)
     /// - the name of the symbol (if there is one)
     /// - NULL
     ///
     /// See also IsInlined().
     const char *
     GetFunctionName();
 
+    const char *
+    GetFunctionName() const;
+
     /// Return true if this frame represents an inlined function.
     ///
     /// See also GetFunctionName().
     bool
     IsInlined();
-    
+    bool
+    IsInlined() const;
+
     /// The version that doesn't supply a 'use_dynamic' value will use the
     /// target's default.
     lldb::SBValue
     EvaluateExpression (const char *expr);    
 
     lldb::SBValue
     EvaluateExpression (const char *expr, lldb::DynamicValueType use_dynamic);
 

scripts/interface/SBFrame.i

~SBFrame();
     /// - the name of the symbol (if there is one)
     /// - NULL
     ///
     /// See also IsInlined().
     ") GetFunctionName;
     const char *
     GetFunctionName();
 
+    const char *
+    GetFunctionName() const;
+
     %feature("docstring", "
     /// Return true if this frame represents an inlined function.
     ///
     /// See also GetFunctionName().
     ") IsInlined;
     bool
     IsInlined();
-    
+    bool
+    IsInlined() const;
+
     %feature("docstring", "
     /// The version that doesn't supply a 'use_dynamic' value will use the
     /// target's default.
     ") EvaluateExpression;
     lldb::SBValue
     EvaluateExpression (const char *expr);    
 
     lldb::SBValue

source/API/SBFrame.cpp

 #endif
 
     return expr_result;
 }
 
 bool
 SBFrame::IsInlined()
 {
+    return static_cast<const SBFrame*>(this)->IsInlined();
+}
+
+bool
+SBFrame::IsInlined() const
+{
     Log *log(GetLogIfAllCategoriesSet (LIBLLDB_LOG_API));
     ExecutionContext exe_ctx(m_opaque_sp.get());
     StackFrame *frame = NULL;
     Target *target = exe_ctx.GetTargetPtr();
     Process *process = exe_ctx.GetProcessPtr();
     if (target && process)
     {
         Process::StopLocker stop_locker;
SBFrame::IsInlined() const
 
     }
     return false;
 }
 
 const char *
 SBFrame::GetFunctionName()
 {
+    return static_cast<const SBFrame*>(this)->GetFunctionName();
+}
+
+const char *
+SBFrame::GetFunctionName() const
+{
     Log *log(lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_API));
     const char *name = NULL;
     ExecutionContext exe_ctx(m_opaque_sp.get());
     StackFrame *frame = NULL;
     Target *target = exe_ctx.GetTargetPtr();
     Process *process = exe_ctx.GetProcessPtr();
     if (target && process)
     {
if (target && process)
         {
             if (log)
                 log->Printf ("SBFrame::GetFunctionName() => error: process is running");
 
         }
     }
     return name;
 }
-