This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/SI: Emit amd_kernel_code_t in EmitFunctionBodyStart()
ClosedPublic

Authored by tstellarAMD on Jun 24 2015, 1:21 PM.

Details

Summary

This way the function symbol points to the start of amd_kernel_code_t
rather than the start of the function.

Diff Detail

Event Timeline

tstellarAMD retitled this revision from to AMDGPU/SI: Emit amd_kernel_code_t in EmitFunctionBodyStart().
tstellarAMD updated this object.
tstellarAMD edited the test plan for this revision. (Show Details)
tstellarAMD added a reviewer: arsenm.
tstellarAMD added a subscriber: Unknown Object (MLST).
arsenm accepted this revision.Jun 24 2015, 2:21 PM
arsenm edited edge metadata.

LGTM

lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp
119

Is this alignment not required anymore?

This revision is now accepted and ready to land.Jun 24 2015, 2:21 PM
lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp
119

Alignment for the function is emitted in EmitFunctionHeader(). We don't need to re-emit it after the AMDKernelCodeT object, because the object is 256 bytes (which is the same as the alignment), so the start of the function, is already aligned properly.

This revision was automatically updated to reflect the committed changes.