This is an archive of the discontinued LLVM Phabricator instance.

[lld] COFF: Ignore debug symbols.
ClosedPublic

Authored by pcc on Jun 23 2015, 5:03 PM.

Reviewers

Commits

pcc retitled this revision from to [lld] COFF: Ignore debug symbols..

pcc updated this object.

pcc edited the test plan for this revision. (Show Details)

pcc added a reviewer: ruiu.

pcc added a subscriber: Unknown Object (MLST).

LGTM

This revision is now accepted and ready to land.Jun 23 2015, 5:06 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lld/

trunk/

COFF/

2 lines

test/

COFF/

38 lines

Show First 20 Lines • Show All 187 Lines • ▼ Show 20 Lines	SymbolBody ObjectFile::createSymbolBody(COFFSymbolRef Sym, const void AuxP,
}		}
if (Sym.isAbsolute()) {		if (Sym.isAbsolute()) {
COFFObj->getSymbolName(Sym, Name);		COFFObj->getSymbolName(Sym, Name);
// Skip special symbols.		// Skip special symbols.
if (Name == "@comp.id" \|\| Name == "@feat.00")		if (Name == "@comp.id" \|\| Name == "@feat.00")
return nullptr;		return nullptr;
return new (Alloc) DefinedAbsolute(Name, Sym.getValue());		return new (Alloc) DefinedAbsolute(Name, Sym.getValue());
}		}
		if (Sym.getSectionNumber() == llvm::COFF::IMAGE_SYM_DEBUG)
		return nullptr;
// TODO: Handle IMAGE_WEAK_EXTERN_SEARCH_ALIAS		// TODO: Handle IMAGE_WEAK_EXTERN_SEARCH_ALIAS
if (Sym.isWeakExternal()) {		if (Sym.isWeakExternal()) {
COFFObj->getSymbolName(Sym, Name);		COFFObj->getSymbolName(Sym, Name);
auto Aux = (const coff_aux_weak_external )AuxP;		auto Aux = (const coff_aux_weak_external )AuxP;
return new (Alloc) Undefined(Name, &SparseSymbolBodies[Aux->TagIndex]);		return new (Alloc) Undefined(Name, &SparseSymbolBodies[Aux->TagIndex]);
}		}
// Handle associative sections		// Handle associative sections
if (IsFirst && AuxP) {		if (IsFirst && AuxP) {
▲ Show 20 Lines • Show All 109 Lines • Show Last 20 Lines

				# RUN: yaml2obj %s > %t.obj
				# RUN: lld -flavor link2 /out:%t.exe /entry:main /subsystem:console %t.obj

				---
				header:
				Machine: IMAGE_FILE_MACHINE_AMD64
				Characteristics: []
				sections:
				- Name: .text
				Characteristics: [ IMAGE_SCN_CNT_CODE, IMAGE_SCN_MEM_EXECUTE, IMAGE_SCN_MEM_READ ]
				Alignment: 4
				SectionData: B82A000000C3
				symbols:
				- Name: .text
				Value: 0
				SectionNumber: 1
				SimpleType: IMAGE_SYM_TYPE_NULL
				ComplexType: IMAGE_SYM_DTYPE_NULL
				StorageClass: IMAGE_SYM_CLASS_STATIC
				SectionDefinition:
				Length: 6
				NumberOfRelocations: 0
				NumberOfLinenumbers: 0
				CheckSum: 0
				Number: 0
				- Name: main
				Value: 0
				SectionNumber: 1
				SimpleType: IMAGE_SYM_TYPE_NULL
				ComplexType: IMAGE_SYM_DTYPE_NULL
				StorageClass: IMAGE_SYM_CLASS_EXTERNAL
				- Name: debug
				Value: 0
				SectionNumber: -2
				SimpleType: IMAGE_SYM_TYPE_NULL
				ComplexType: IMAGE_SYM_DTYPE_NULL
				StorageClass: IMAGE_SYM_CLASS_EXTERNAL
				...