This is an archive of the discontinued LLVM Phabricator instance.

Remove old local-only linux debugging code
ClosedPublic

Authored by labath on Jun 23 2015, 10:31 AM.

Details

Summary

Currently, the local-only path fails about 50% of the tests, which means that: a) nobody is using
it; and b) the remote debugging path is much more stable. This commit removes the local-only
linux debugging code (ProcessLinux) and makes remote-loopback the only way to debug local
applications (the same architecture as OSX). The ProcessPOSIX code is moved to the FreeBSD
directory, which is now the only user of this class. Hopefully, FreeBSD will soon move to the new
architecture as well and then this code can be removed completely.

Diff Detail

Repository
rL LLVM

Event Timeline

labath updated this revision to Diff 28261.Jun 23 2015, 10:31 AM
labath retitled this revision from to Remove old local-only linux debugging code.
labath updated this object.
labath edited the test plan for this revision. (Show Details)
labath added reviewers: emaste, vharron, ovyalov, clayborg.
labath added a subscriber: Unknown Object (MLST).
clayborg accepted this revision.Jun 23 2015, 1:20 PM
clayborg edited edge metadata.

lgtm

This revision is now accepted and ready to land.Jun 23 2015, 1:20 PM
ovyalov accepted this revision.Jun 23 2015, 6:02 PM
ovyalov edited edge metadata.

LGTM

This revision was automatically updated to reflect the committed changes.
lldb/trunk/source/Plugins/Process/POSIX/RegisterContextPOSIXProcessMonitor_x86.h