This is an archive of the discontinued LLVM Phabricator instance.

Differential D104206

[ms] [llvm-ml] Fix capitalization of the ignored CPU directives
ClosedPublic

Authored by epastor on Jun 13 2021, 3:31 PM.

Details

Reviewers
None
Commits
rGd81c059c3ed2: [ms] [llvm-ml] Fix capitalization of the ignored CPU directives
Summary

These directives are matched in lowercase, so make sure to use lowercase for their P suffix.

Diff Detail

Event Timeline

epastor created this revision.Jun 13 2021, 3:31 PM
Herald added a subscriber: hiraditya. · View Herald TranscriptJun 13 2021, 3:31 PM
epastor requested review of this revision.Jun 13 2021, 3:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2021, 3:31 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
This revision was not accepted when it landed; it landed in state Needs Review.Jun 13 2021, 3:37 PM
This revision was landed with ongoing or failed builds.
Closed by commit rGd81c059c3ed2: [ms] [llvm-ml] Fix capitalization of the ignored CPU directives (authored by epastor). · Explain Why
This revision was automatically updated to reflect the committed changes.
epastor added a commit: rGd81c059c3ed2: [ms] [llvm-ml] Fix capitalization of the ignored CPU directives.
Harbormaster completed remote builds in B109036: Diff 351746.Jun 13 2021, 4:16 PM

Revision Contents

PathSize
llvm/
lib/
MC/
MCParser/
8 lines
test/
tools/
llvm-ml/
12 lines

Diff 351748

llvm/lib/MC/MCParser/COFFMasmParser.cpp

Show First 20 Lines • Show All 132 Lines • ▼ Show 20 Lines void Initialize(MCAsmParser &Parser) override {
// Procedure directives // Procedure directives
addDirectiveHandler<&COFFMasmParser::ParseDirectiveEndProc>("endp"); addDirectiveHandler<&COFFMasmParser::ParseDirectiveEndProc>("endp");
// invoke (32-bit only) // invoke (32-bit only)
addDirectiveHandler<&COFFMasmParser::ParseDirectiveProc>("proc"); addDirectiveHandler<&COFFMasmParser::ParseDirectiveProc>("proc");
// proto // proto
// Processor directives; all ignored // Processor directives; all ignored
addDirectiveHandler<&COFFMasmParser::IgnoreDirective>(".386"); addDirectiveHandler<&COFFMasmParser::IgnoreDirective>(".386");
addDirectiveHandler<&COFFMasmParser::IgnoreDirective>(".386P"); addDirectiveHandler<&COFFMasmParser::IgnoreDirective>(".386p");
addDirectiveHandler<&COFFMasmParser::IgnoreDirective>(".387"); addDirectiveHandler<&COFFMasmParser::IgnoreDirective>(".387");
addDirectiveHandler<&COFFMasmParser::IgnoreDirective>(".486"); addDirectiveHandler<&COFFMasmParser::IgnoreDirective>(".486");
addDirectiveHandler<&COFFMasmParser::IgnoreDirective>(".486P"); addDirectiveHandler<&COFFMasmParser::IgnoreDirective>(".486p");
addDirectiveHandler<&COFFMasmParser::IgnoreDirective>(".586"); addDirectiveHandler<&COFFMasmParser::IgnoreDirective>(".586");
addDirectiveHandler<&COFFMasmParser::IgnoreDirective>(".586P"); addDirectiveHandler<&COFFMasmParser::IgnoreDirective>(".586p");
addDirectiveHandler<&COFFMasmParser::IgnoreDirective>(".686"); addDirectiveHandler<&COFFMasmParser::IgnoreDirective>(".686");
addDirectiveHandler<&COFFMasmParser::IgnoreDirective>(".686P"); addDirectiveHandler<&COFFMasmParser::IgnoreDirective>(".686p");
addDirectiveHandler<&COFFMasmParser::IgnoreDirective>(".k3d"); addDirectiveHandler<&COFFMasmParser::IgnoreDirective>(".k3d");
addDirectiveHandler<&COFFMasmParser::IgnoreDirective>(".mmx"); addDirectiveHandler<&COFFMasmParser::IgnoreDirective>(".mmx");
addDirectiveHandler<&COFFMasmParser::IgnoreDirective>(".xmm"); addDirectiveHandler<&COFFMasmParser::IgnoreDirective>(".xmm");
// Scope directives // Scope directives
// comm // comm
// externdef // externdef
▲ Show 20 Lines • Show All 259 Lines • Show Last 20 Lines

llvm/test/tools/llvm-ml/ml32-context.asm

  • This file was added.
# RUN: llvm-ml -m32 -filetype=s %s /Fo - | FileCheck %s
.386p
.model flat
.code
mov eax, eax
end
; CHECK-NOT: 386p
; CHECK-NOT: model
; CHECK-NOT: flat