[LNT] Add --qemu-flags option in addition to --qemu-flag

[• chatur01]

Summary

In a similar way to the cflag changes in D10364, add --qemu-flags.
Also refactored the unix argument quoting stuff into its own function.

[cmatthews]

LGTM.

[• chatur01]

Landed r240274.

lnt/tests/nt.py

 
         if self.cflag_string:
             # FIXME: This isn't generally OK on Windows :/
-            safely_quoted_on_unix = map(pipes.quote, shlex.split(self.cflag_string))
-            target_flags.extend(safely_quoted_on_unix)
+            target_flags.extend(_unix_quote_args(self.cflag_string))
 
         # Pass flags to backend.
         for f in self.mllvm:

     def qemu_user_mode_command(self):
         """ The command used for qemu user mode """
         assert self.qemu_user_mode
-        return ' '.join([self.qemu_user_mode] + self.qemu_flags)
+        qemu_cmd_line = [self.qemu_user_mode] + self.qemu_flags
+        if self.qemu_string:
+            qemu_cmd_line += _unix_quote_args(self.qemu_string)
+        return ' '.join(qemu_cmd_line)
 
     @property
     def generate_report_script(self):

     assert len(results) > 0
     return results
 
+def _unix_quote_args(s):
+    return map(pipes.quote, shlex.split(s))
 
 # When set to true, all benchmarks will be rerun.
 # TODO: remove me when rerun patch is done.

         group.add_option("", "--qemu-flag", dest="qemu_flags",
                          help="Additional flags to pass to qemu",
                          action="append", type=str, default=[], metavar="FLAG")
+        group.add_option("", "--qemu-flags", dest="qemu_string",
+                         help="Additional flags to pass to qemu, space separated string. "
+                         "These flags are appended after *all* the individual "
+                         "--qemu-flag arguments.",
+                         type=str, default='', metavar="FLAG")
 
         group.add_option("", "--multisample", dest="multisample",
                          help="Accumulate test data from multiple runs",

         # test-suite directory, that borks things. <rdar://problem/7876418>
         prepare_report_dir(config)
 
+        # These notes are used by the regression tests to check if we've handled
+        # flags correctly.
         note('TARGET_FLAGS: {}'.format(' '.join(config.target_flags)))
+        if config.qemu_user_mode:
+            note('QEMU_USER_MODE_COMMAND: {}'.format(config.qemu_user_mode_command))
 
         # Multisample, if requested.
         if opts.multisample is not None:

tests/runtest/nt.py

 # RUN: FileCheck --check-prefix CHECK-CFLAG5 < %t.err %s
 # CHECK-CFLAG5: inferred C++ compiler under test
 # CHECK-CFLAG5: TARGET_FLAGS: --target=armv7a-none-eabi -Weverything -Wall '-test=escaped space' '-some-option=stay with me' -O3
+
+# Qemu flag handling
+# RUN: lnt runtest nt \
+# RUN:   --sandbox %t.SANDBOX \
+# RUN:   --test-suite %S/Inputs/test-suite \
+# RUN:   --cc %{shared_inputs}/FakeCompilers/clang-r154331 \
+# RUN:   --qemu-user-mode TEST \
+# RUN:   --qemu-flag '-soundhw gus' \
+# RUN:   --qemu-flag '-net nic' \
+# RUN:   --qemu-flags '-device gus,irq=5 -test=escaped\ space -some-option="stay with me"' \
+# RUN:   --no-timestamp > %t.log 2> %t.err
+# RUN: FileCheck --check-prefix CHECK-QEMU-FLAG1 < %t.err %s
+# CHECK-QEMU-FLAG1: QEMU_USER_MODE_COMMAND: TEST -soundhw gus -net nic -device gus,irq=5 '-test=escaped space' '-some-option=stay with me'