This is an archive of the discontinued LLVM Phabricator instance.

Fix typo in cross-compilation docs: -fpu -> -mfpu
ClosedPublic

Authored by vsukharev on Jun 3 2015, 2:41 AM.

Download Raw Diff

Details

Reviewers

Commits

rGc85ed8567c07: Fix typo in cross-compilation docs: "-fpu" -> "-mfpu"
rC238912: Fix typo in cross-compilation docs: "-fpu" -> "-mfpu"
rL238912: Fix typo in cross-compilation docs: "-fpu" -> "-mfpu"

Summary

Using currently documented "-fpu" option, I face an error:
$ clang --target=arm-none-eabi -mcpu=cortex-a9 -fpu=vfpv3-fp16 ~/tmp/hello.c
clang-3.7: error: unknown argument: '-fpu=vfpv3-fp16'

Though "-mfpu" option works fine. So "-fpu" seems like a typo in docs

Diff Detail

Repository: rL LLVM

Event Timeline

vsukharev updated this revision to Diff 27028.Jun 3 2015, 2:41 AM

vsukharev retitled this revision from to Fix typo in cross-compilation docs: -fpu -> -mfpu.

vsukharev updated this object.

vsukharev edited the test plan for this revision. (Show Details)

vsukharev added a reviewer: rengolin.

vsukharev set the repository for this revision to rL LLVM.

vsukharev added a subscriber: Unknown Object (MLST).

Herald added a subscriber: aemerson. · View Herald TranscriptJun 3 2015, 2:41 AM

Ouch, looks like a typo. LGTM, Thanks!

This revision is now accepted and ready to land.Jun 3 2015, 2:52 AM

Closed by commit rL238912: Fix typo in cross-compilation docs: "-fpu" -> "-mfpu" (authored by vsukharev). · Explain WhyJun 3 2015, 3:15 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

cfe/

trunk/

docs/

CrossCompilation.rst

2 lines

Diff 27030

cfe/trunk/docs/CrossCompilation.rst

	Show First 20 Lines • Show All 104 Lines • ▼ Show 20 Lines
	-------------			-------------

	Once your target is specified, it's time to pick the hardware you'll			Once your target is specified, it's time to pick the hardware you'll
	be compiling to. For every architecture, a default set of CPU/FPU/ABI			be compiling to. For every architecture, a default set of CPU/FPU/ABI
	will be chosen, so you'll almost always have to change it via flags.			will be chosen, so you'll almost always have to change it via flags.

	Typical flags include:			Typical flags include:
	* ``-mcpu=<cpu-name>``, like x86-64, swift, cortex-a15			* ``-mcpu=<cpu-name>``, like x86-64, swift, cortex-a15
	* ``-fpu=<fpu-name>``, like SSE3, NEON, controlling the FP unit available			* ``-mfpu=<fpu-name>``, like SSE3, NEON, controlling the FP unit available
	* ``-mfloat-abi=<fabi>``, like soft, hard, controlling which registers			* ``-mfloat-abi=<fabi>``, like soft, hard, controlling which registers
	to use for floating-point			to use for floating-point

	The default is normally the common denominator, so that Clang doesn't			The default is normally the common denominator, so that Clang doesn't
	generate code that breaks. But that also means you won't get the best			generate code that breaks. But that also means you won't get the best
	code for your specific hardware, which may mean orders of magnitude			code for your specific hardware, which may mean orders of magnitude
	slower than you expect.			slower than you expect.

	▲ Show 20 Lines • Show All 82 Lines • Show Last 20 Lines